You're right! It looks like dead code that should be removed. Gary.
On Wed, Oct 20, 2010 at 12:50, aaron morton <aa...@thelastpickle.com> wrote: > I should have mentioned the FailureDetectorMBean only has the parameterless > dumpInterArrivalTimes(). > > The overload that takes InetAddress is not available through JMX. > > A > On 21 Oct 2010, at 01:55, Gary Dusbabek wrote: > >> Yes, we should generate it in the right temp directory. That method >> is an implementation of an interface method (FailureDetectorMBean), >> meant to be invoked by JMX, which is why no other code calls it. >> >> Gary. >> >> On Wed, Oct 20, 2010 at 03:48, aaron morton <aa...@thelastpickle.com> wrote: >>> I was reading through some code and noticed the following in >>> FailureDetector.dumpInterArrivealTimes() >>> >>> FileOutputStream fos = new FileOutputStream("/var/tmp/output-" + >>> System.currentTimeMillis() + ".dat", true); >>> >>> If this is meant to be cross platform I'm happy to create a bug and change >>> it to use File.createTempFile() . >>> >>> Also I could not find any use of the dumpInterArrivalTimes(InetAddress ep) >>> overload. Anyone know if it should be kept? >>> >>> thanks >>> Aaron >>> >>> > >