I've added the JMX work to StorageService and NodeTool so this work is done, ready for final review, thanks
https://issues.apache.org/jira/secure/attachment/12443404/CASSANDRA-531.patch On Sun, May 2, 2010 at 12:05 AM, Ran Tavory <ran...@gmail.com> wrote: > alright, I've uploaded another patch with these updates: > > > https://issues.apache.org/jira/secure/attachment/12443391/CASSANDRA-531.patch > > In this patch I completed all the thrift wiring work, including internal > messaging to all hosts in the cluster. > The patch includes all previous changes, no need to use the previous > patches. > I've changed the truncate method definition in cassandra.thrift and removed > the timestamp from the truncation signature since it's not used. > More changes are in the patch, including system test, thrift and messaging > implementation, taking a snapshot and deleting the actual files. > > TODO: > Add truncate to the JMX interface > Add truncate to nodetool > Add system tests to test nodetool + JMX > > > On Wed, Apr 28, 2010 at 2:53 PM, Gary Dusbabek <gdusba...@gmail.com>wrote: > >> You bet. Take a look at CFS.snapshot(). You basically supply a name >> and a hard link is created. >> >> Gary. >> >> On Wed, Apr 28, 2010 at 06:49, Ran Tavory <ran...@gmail.com> wrote: >> > Thanks Gary, can you send a code pointer how snapshot is done? >> > >> > On Wed, Apr 28, 2010 at 2:46 PM, Gary Dusbabek <gdusba...@gmail.com> >> wrote: >> >> >> >> I think it's in the right direction. You've handled the memtable, >> >> sstables and commit log. Other than what's listed in the todos, I >> >> can't think of anything else. >> >> >> >> As for the files, it's probably best to snapshot before truncating. >> >> That's the approach I was encouraged to take for the DROP CF >> >> operation. >> >> >> >> Gary. >> >> >> >> On Wed, Apr 28, 2010 at 03:59, Ran Tavory <ran...@gmail.com> wrote: >> >> > Finally I found the time to start this work... >> >> > It's half baked, but I listed all the missing parts so I'll continue >> the >> >> > work if the patch is good so far. No need to apply the patch, just >> have >> >> > look >> >> > and lmk if I'm at the right direction >> >> > >> >> > >> https://issues.apache.org/jira/secure/attachment/12443055/CASSANDRA-531.patch >> >> > >> >> > >> >> > < >> https://issues.apache.org/jira/secure/attachment/12443055/CASSANDRA-531.patch >> > >> >> > Thanks >> >> > >> >> > On Thu, Mar 25, 2010 at 9:32 PM, Jonathan Ellis <jbel...@gmail.com> >> >> > wrote: >> >> > >> >> >> Commented on the Jira issue. >> >> >> >> >> >> Curious how badly out of date that patch is now. :) >> >> >> >> > >> > >> > >
