Indhumathi27 commented on a change in pull request #4180:
URL: https://github.com/apache/carbondata/pull/4180#discussion_r694890915
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala
##########
@@ -169,13 +167,14 @@ private[sql] case class
CarbonAlterTableColRenameDataTypeChangeCommand(
newColumnScale)) {
isDataTypeChange = true
}
- if (DataTypes.isArrayType(oldDatatype) ||
DataTypes.isStructType(oldDatatype)) {
+ if (DataTypes.isArrayType(oldDatatype) ||
DataTypes.isStructType(oldDatatype) ||
Review comment:
This check also can be moved to some utility class and reuse in the
places used in this code change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
