Indhumathi27 commented on a change in pull request #4115:
URL: https://github.com/apache/carbondata/pull/4115#discussion_r614571362
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
##########
@@ -255,6 +276,10 @@ class AlterTableColumnSchemaGenerator(
// add new dimension columns
alterTableModel.dimCols.foreach(field => {
+ if (field.dataType.get.equals("Map")) {
Review comment:
Can use CarbonCommonConstants.MAP constant
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
##########
@@ -319,10 +373,6 @@ class AlterTableColumnSchemaGenerator(
sys.error(s"Duplicate column found with name: $name")
})
- if (newCols.exists(_.getDataType.isComplexType)) {
Review comment:
Please update document
[Alter-add](https://github.com/apache/carbondata/blob/master/docs/ddl-of-carbondata.md#add-columns)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
