chenBright commented on code in PR #3255:
URL: https://github.com/apache/brpc/pull/3255#discussion_r3019478629
##########
src/brpc/rdma/rdma_endpoint.cpp:
##########
@@ -1250,6 +1206,21 @@ int RdmaEndpoint::BringUpQp(uint16_t lid, ibv_gid gid,
uint32_t qp_num) {
return -1;
}
+ if (FLAGS_rdma_ece) {
+ struct ibv_ece ece;
+ int err = IbvQueryEce(_resource->qp, &ece);
+ if (err != 0) {
+ LOG(WARNING) << "Fail to IbvQueryEce: " << berror(err);
+ return -1;
+ }
+ // ToDo: should check if remote qp support ece
Review Comment:
What happens if one side does not support ECN? Is negotiation necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
