amoxic commented on PR #3250: URL: https://github.com/apache/brpc/pull/3250#issuecomment-4132164286
Thanks for the review. Addressed all Copilot comments: 1) Stream::SetHostSocket now records the first failure in _set_host_socket_ec and always sets errno from that value on failure (no more call_once stack-local loss). 2) All callers now check SetHostSocket return and fail controller/streams on error: SendRpcResponse main stream + extra streams, Controller::HandleStreamConnection. 3) Bind failures propagate errno directly (no reliance on sock->non_zero_error_code). 4) Stream::SetFailed now preformats the reason string (SetFailedWithReason helper) to avoid varargs UB; all new call sites use the safe path. 5) Added regression tests covering SetHostSocket failure and server-side disconnect-before-response; both pass locally (`brpc_streaming_rpc_unittest` filtered run). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
