Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#issuecomment-157683343
Iâve made most of the changes to the simple command classes from the
review comments. The driver is gone, but I have had trouble trying to get rid
of the lifecycle effector stuff entirely (thought the class is simpler) â
without it my unit tests fail to get the MachineLocation.
Pushing back the changes so far. Maybe itâs now simple enough to be ok
as-is.
I meant to mention before the reason thereâs a separate
SimpleShellCommand and a SimpleShellCommandTest subclass was that I tried to
keep a âseparation of concernsâ between invoking the command and testing
the results (with a notion that SimpleShellCommand might be useful in its own
right apart from tests). But I could collapse those together to cut down the
number of classes. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
