[
https://issues.apache.org/jira/browse/BROOKLYN-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985277#comment-14985277
]
ASF GitHub Bot commented on BROOKLYN-190:
-----------------------------------------
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/997#discussion_r43632335
--- Diff: core/src/test/java/org/apache/brooklyn/core/test/HttpService.java
---
@@ -128,15 +131,21 @@ public HttpService start() throws Exception {
} finally {
keyStoreStream.close();
}
-
+
+ // manually create like seen in XMLs at
http://www.eclipse.org/jetty/documentation/current/configuring-ssl.html
SslContextFactory sslContextFactory = new
SslContextFactory();
sslContextFactory.setKeyStore(keyStore);
sslContextFactory.setTrustAll(true);
sslContextFactory.setKeyStorePassword("password");
- SslSocketConnector sslSocketConnector = new
SslSocketConnector(sslContextFactory);
- sslSocketConnector.setPort(actualPort);
- server.addConnector(sslSocketConnector);
+ HttpConfiguration sslHttpConfig = new HttpConfiguration();
+ sslHttpConfig.setSecureScheme("https");
+ sslHttpConfig.setSecurePort(actualPort);
+
+ ServerConnector httpsConnector = new
ServerConnector(server, new SslConnectionFactory(sslContextFactory,
"http/1.1"), new HttpConnectionFactory(sslHttpConfig));
--- End diff --
Can use `HttpVersion.HTTP_1_1.asString()` instead.
> Upgrade to Jetty9
> -----------------
>
> Key: BROOKLYN-190
> URL: https://issues.apache.org/jira/browse/BROOKLYN-190
> Project: Brooklyn
> Issue Type: Improvement
> Affects Versions: 0.8.0, 0.9.0
> Reporter: Ciprian Ciubotariu
> Assignee: Ciprian Ciubotariu
> Priority: Minor
> Fix For: 0.9.0
>
>
> According to [1] jetty9 is now the stable version.
> In relation to BROOKLYN-183, current stable pax-web 4.x series also support
> Jetty9 (although I believe it can be used with Jetty8 as well). However,
> migrating Brooklyn to a more current Jetty version seems preferable.
> [1] http://www.eclipse.org/jetty/documentation/current/what-jetty-version.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
