[ 
https://issues.apache.org/jira/browse/BROOKLYN-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14973931#comment-14973931
 ] 

Svetoslav Neykov commented on BROOKLYN-133:
-------------------------------------------

Diego thanks for the patch, could you follow the steps in the "How to 
contribute" guide at 
https://brooklyn.incubator.apache.org/developers/how-to-contribute.html. In 
essence:
  * file an Apache ICLA
  * create a PR against the github repo at 
https://github.com/apache/incubator-brooklyn/

Also this seems to be a problem only if supplying BROOKLYN_HOME manually. When 
it's not set the script will correctly initialize it with a trailing slash. 
Either strip the trailing slash in the auto-discovery case or append it only if 
missing.

> brooklyn.bat requires BROOKLYN_HOME to have a trailing "\" on Windows
> ---------------------------------------------------------------------
>
>                 Key: BROOKLYN-133
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-133
>             Project: Brooklyn
>          Issue Type: Bug
>    Affects Versions: 0.7.0-M2
>         Environment: Windows 7 x64
>            Reporter: David Taylor
>            Priority: Minor
>              Labels: windows
>         Attachments: Screen Shot 2015-03-05 at 21.17.12.png, 
> brooklyn.bat.patch
>
>
> Brooklyn fails to launch on Windows if BROOKLYN_HOME does not include a 
> trailing "\". This occurs because of the classpath is constructed by string 
> concatenation without the required path delimiter:
> e.g. %BROOKLYN_HOME%lib\brooklyn\*
> The batch file should be modified to function correctly with or without the 
> trailing path delimiter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to