Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/983#discussion_r42742105
--- Diff:
software/base/src/test/java/org/apache/brooklyn/entity/machine/SetHostnameCustomizerTest.java
---
@@ -64,4 +68,20 @@ public void
testGeneratedHostnameUsesPublicIpIfEmptyListOfPrivate() throws Excep
assertEquals(customizer.generateHostname(machine),
"ip-4-3-2-1-"+machine.getId());
}
+
+ @Test
+ public void testGeneratedHostnameIfNoIps() throws Exception {
+ SshMachineLocation machine =
mgmt.getLocationManager().createLocation(LocationSpec.create(SshMachineLocationWithNoPublicIps.class)
+ .configure("address", "4.3.2.1"));
--- End diff --
I tested it. The test was ok without it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
