GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/912
Fix service-not-up-diagnostics, add subscription.notifyOfInitialValue, etc
Various fixes for things encountered (or speculatively encountered for
"notifyOfInitialValue"!) when testing upgrade from an old Brooklyn to a new
brooklyn.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn various/20150918
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/912.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #912
----
commit a2c03ae8fd4c14bdcde928c6593afbe10152f5e0
Author: Aled Sage <[email protected]>
Date: 2015-09-18T18:26:41Z
Fix synchronization in DeserializingClassRenamesProvider
Fix bad use of double-checked locking.
commit 1b1079a2c9b275146783518c0258cf8d1cc3cd65
Author: Aled Sage <[email protected]>
Date: 2015-09-18T18:27:03Z
yaml DSL: use class-renames for sensor/object
commit 3ae0d02de5a18be5116645931027498e7d33ebc9
Author: Aled Sage <[email protected]>
Date: 2015-09-18T18:34:33Z
Update deprecated code in subscription tests
commit 0895a7298c6177a33adb285190c5a8011968008f
Author: Aled Sage <[email protected]>
Date: 2015-09-18T18:55:29Z
subscriptions: support notifyOfInitialValue
If pass in notifyOfInitialValue=true when subscribing to a single
entity:attribute, then the listener will be called with the current
value (rather than waiting for the first change).
commit 7f96be31e9f0255f3f632d8ff84b76081709205c
Author: Aled Sage <[email protected]>
Date: 2015-09-18T19:00:11Z
Fix SoftwareProcess.ServiceNotUpDiagnosticsCollector race
Previously we subscribed to serviceUp and then called onUpdated.
However, this meant that it could execute onUpdated in two threads
concurrently (if we very quickly got a callback of serviceUp changing).
Instead we now use ânotifyOfInitialValueâ, which will call us in our
event-handling thread with the initial value of the sensor as a
pseudo-event for the subscription manager.
commit 2d134f494c13833c8320707e30e5e7423f16ced6
Author: Aled Sage <[email protected]>
Date: 2015-09-18T19:52:51Z
ServiceNotUpDiagnostics: populate properly
Previously we only re-populated the ServiceNotUpDiagnostics when
serviceUp changed. However, this meant we did it once at the start
(where it said âno-driverâ) and then not again if startup failed,
so serviceUp was left as âfalseâ.
Now we also re-populate the ServiceNotUpDiagnostics if the serviceState
changes (and serviceUp=false), e.g. if we conclude on-fire etc.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
