PookieBuns opened a new pull request, #519:
URL: https://github.com/apache/avro-rs/pull/519

   Drafted up an initial PR to support #517
   
   However, I would like y'alls input before I proceed further. Specifically, 
whether we should support Union branch lookup via enum variant name (new 
behavior, breaking change), or keep using variant index. I personally am more 
in favor of variant name, since it seems more intuitive to me wrt I don't have 
to worry about the order of my enum variants (and now you can actually use 
`#[serde(other)]` because that required it to be the last variant). I guess the 
cons of this is worse performance since there is O(n) lookup rather than direct 
indexing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to