sarutak opened a new pull request, #2405:
URL: https://github.com/apache/avro/pull/2405
AVRO-3818
## What is the purpose of the change
This PR fixes an issue that with the current Rust binding, inner named types
don't inherit their enclosing namespace even though they have no their own
namespace.
Given we have a schema like as follows.
```
{
"namespace": "my_ns",
"type": "record",
"aliases": ["my_alias"],
"name": "my_schema",
"fields": [
{
"name": "f1",
"type": {
"name": "enum1",
"type": "enum",
"symbols": ["a"]
}
}
]
}
```
In the canonical form of this schema, the fullname of `enum1` should be
`my_ns.enum1` because it has no their own namespace and the enclosing
namespace is `my_ns`.
```
{"name":"my_ns.my_schema","type":"record","fields":[{"name":"f1","type":{"name":"my_ns.enum1","type":"enum","symbols":["a"]}}]}
```
But the current implementation makes the fullname of `enum1` as `enum1`.
```
{"name":"my_ns.my_schema","type":"record","fields":[{"name":"f1","type":{"name":"enum1","type":"enum","symbols":["a"]}}]}
```
## Verifying this change
Added new tests and modified existing tests which was wrong.
These tests passed with `cargo test --tests`.
## Documentation
No new features added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
