> On June 20, 2017, 2:51 a.m., David Radley wrote:
> > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
> > Lines 131 (patched)
> > <https://reviews.apache.org/r/59769/diff/6/?file=1753846#file1753846line131>
> >
> > the method name is isTypeOrSuperTypeOf, but the check is of subtypes.
> > Is this what you intended?
This is little tricky. For e.g.
<DataSet_Type>.isTypeOrSuperTypeOf("hive_table") ->
typeAndAllSubTypes list will contain current type (DataSet) and all its sub
types.
typeAndAllSubTypes contains typeAndAllSubTypes.
> On June 20, 2017, 2:51 a.m., David Radley wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
> > Lines 222 (patched)
> > <https://reviews.apache.org/r/59769/diff/6/?file=1753852#file1753852line222>
> >
> > I assume we need to validate the attribute name as well as the
> > AtlasObjectId content.
Good catch, added validateAndNormalize() for relationship attributes. We
validate contents of AtlasbjectId in validateEnd() method.
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59769/#review178356
-----------------------------------------------------------
On June 19, 2017, 6:55 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59769/
> -----------------------------------------------------------
>
> (Updated June 19, 2017, 6:55 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj,
> Nixon Rodrigues, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1856
> https://issues.apache.org/jira/browse/ATLAS-1856
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Based on the relationDef implementation in ATLAS-1852. Implement instance API
> and REST for entity relationships. This patch is not complete.
> work in progress
>
>
> Diffs
> -----
>
>
> authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java
> deccf843
>
> authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java
> 93d988e6
>
> authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java
> 7ef49e66
>
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
> bd7b35e4
>
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java
> 662a2705
>
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java
> 056088cf
>
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java
> 5ad176b5
>
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java
> e829d918
>
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java
> 9dc175b6
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6c33f402
> intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java
> PRE-CREATION
>
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipEndDef.java
> 000d747b
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 0ff15827
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java
> eb2fc48b
> intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java aebd4d1a
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
> ca7fad06
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasRelationshipStore.java
> PRE-CREATION
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
> 560b3385
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
> PRE-CREATION
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
> 66f20daa
>
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java
> 7a064b60
> repository/src/test/java/org/apache/atlas/TestModules.java 095af417
> webapp/src/main/java/org/apache/atlas/web/rest/RelationshipREST.java
> PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/59769/diff/6/
>
>
> Testing
> -------
>
> Tested using POSTMAN. UTs and ITs in progress.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
