-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58803/#review174476
-----------------------------------------------------------



I managed to get this to build and ran it against an IBM Graph instance. But 
there are a number of things that needed changes/workarounds to get it working:

1. The atlas-graphdb-ibm-graph build relies on the java-8 build profile being 
activated so that it can set skipMain and skip to false, so that the ibm-graph 
component gets built.  The java-8 profile has an activation rule of:

        <profile>
            <id>java-8</id>
            <activation>
                <jdk>1.8</jdk>
            </activation>        
            <build>
              .. etc
..but even when running with a 1.8 Java environment the profile was not 
activated. It was therefore necessary to explicitly activate the profile, by 
including -Pjava-8 on the maven command line. With both the java-8 and 
ibm-graph profiles explicitly named, it worked and the ibm-graph component was 
built.

2. When the ibm-graph profile is built, the resulting packaged jar contains 
both ibm-graph and titan0. The different graph providers are assumed to be 
mutually exclusive as indicated by the maven dependency exclusions (e.g. if 
titan0, exclude titan0 and ibm-graph). There must be an unintended transitive 
dependency on titan0. I didn't bother to fix this (in the pom files) because 
I'm not sure that mutual exclusion is actually the best approach so I raised 
this as a question on JIRA ATLAS-1757.

3. With the above changes, the ibm-graph profile builds, but when testing it 
(atlas_start.py followed by quick_start.py) there is an NPE when trying to 
loadGraphUpdateScript. This is because the readStream is null because the 
script file path is incorrectly specified: the web root is "src/main/resources" 
so the groovy script uri should be "graphUpdater.groovy" rather than 
"src/main/resources/graphUpdater.groovy".

4. With the above changes, it is possible to connect to an IBM Graph instance 
and to run through the quick_start.py, but not completely cleanly. I detected 
the following errors:

2017-05-09 15:42:53,586 INFO  - [pool-1-thread-10:] ~ 
test-1-graph:Test-1-Graph: e26d0d19-7163-4687-9608-6113d915cfc5:  begin 
transaction e26d0d19-7163-4687-9608-6113d915cfc5 (IBMGraphGraph:974)
2017-05-09 15:42:53,587 INFO  - [pool-1-thread-10 - 
55ad3ab1-8acb-4647-9874-5b7741b8d2b6:] ~ test-1-graph:Test-1-Graph: 
bf922368-abaa-4354-b942-d63b40044c56:  begin transaction 
bf922368-abaa-4354-b942-d63b40044c56 (IBMGraphGraph:974)
2017-05-09 15:42:53,678 ERROR - [pool-1-thread-10 - 
55ad3ab1-8acb-4647-9874-5b7741b8d2b6:] ~ Error handling a request: 
e417ee56dcfcd88d (ExceptionMapperUtil:32)
org.apache.atlas.ibmgraph.exception.BadRequestException: Request POST 
https://ibmgraph-alpha.eu-gb.bluemix.net/be6aad23-26ca-4776-9b2a-b3ccffa90f63/test-1-graph/gremlin
{"gremlin":"import java.util.function.Function;import 
org.apache.tinkerpop.gremlin.process.traversal.strategy.decoration.PartitionStrategy;import
 static org.apache.tinkerpop.gremlin.process.traversal.P.*;def 
g=graph.traversal();g.V().has('__typeName', T.in, typeNames) 
[startIdx..<endIdx].toList()","bindings":{"typeNames":["hbase_table"],"endIdx":25,"startIdx":0}}
 failed.  Failure response: HttpResponse[Status = 400 - Bad Request, IBM Graph 
Request Id = c20f2b5e-b693-41f3-982c-2dc6c14791b5]
Response Body:
{"code":"BadRequestError","message":"[Static type checking] - No such property: 
in for class: java.lang.Class <org.apache.tinkerpop.gremlin.structure.T>, 
[Static type checking] - Cannot find matching method 
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal#has(java.lang.String,
 java.lang.Object, java.util.ArrayList <E extends java.lang.Object>). Please 
check if the declared type is right and if the method exists."}
        at 
org.apache.atlas.ibmgraph.http.HttpRequestHandler.handleFailures(HttpRequestHandler.java:250)
        at 
org.apache.atlas.ibmgraph.http.HttpRequestHandler.translateResponse(HttpRequestHandler.java:199)
        at 
org.apache.atlas.ibmgraph.http.HttpRequestHandler.processRequest_(HttpRequestHandler.java:140)
        at 
org.apache.atlas.ibmgraph.http.HttpRequestHandler.processRequest(HttpRequestHandler.java:108)
        at 
org.apache.atlas.ibmgraph.api.GraphDatabaseClient.processMultiValuedRequest(GraphDatabaseClient.java:124)
        at 
org.apache.atlas.ibmgraph.api.GraphDatabaseClient.executeGremlin(GraphDatabaseClient.java:239)
        at 
org.apache.atlas.ibmgraph.api.GraphDatabaseClient.executeGremlin(GraphDatabaseClient.java:227)
    
I think the problem here is that Atlas is trying to use Tinkerpop 2 syntax with 
a Tinkerpop 3 graph; hence the confusion looking for an 'in' property for the 
class 'T'. In TP3, there are first-class predicates, such as within(), that I 
think should be used for this query. So it seems like the code is picking up 
the AtlasGremlin2QueryProvider instead of the AtlasGremlin3QueryProvider. This 
may be due to the inadvertant inclusion of titan0 in the build as well as 
ibm-graph, see point 2 above. Or maybe it is something else - I have not had a 
chance to get to the bottom of this problem yet. I will look into how 
AtlasGraphProvider is supposed to work.

- Graham Wallis


On May 4, 2017, 4:35 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58803/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 4:35 p.m.)
> 
> 
> Review request for atlas, David Radley, David Kantor, Graham Wallis, Neeru 
> Gupta, and Jeff Hagelberg.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> See https://reviews.apache.org/r/56724/
> 
> Since the review is outdated and lot of conflicting changes have happened 
> over the course of time. This review addresses those conflicts.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/GraphInitializationException.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/groovy/LiteralExpression.java 
> 14074994 
>   
> common/src/main/java/org/apache/atlas/groovy/VariableAssignmentExpression.java
>  1aa74435 
>   distro/pom.xml f0962b6c 
>   distro/src/conf/atlas-application.properties b2b8e745 
>   distro/src/conf/credentials.json PRE-CREATION 
>   distro/src/main/assemblies/standalone-package.xml 215cb236 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
> a3a27bfd 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java
>  3dfc6e8d 
>   graphdb/graphdb-impls/pom.xml feafe742 
>   graphdb/ibm-graph/pom.xml PRE-CREATION 
>   graphdb/ibm-graph/readme-multitenancy-support.txt PRE-CREATION 
>   graphdb/ibm-graph/readme.txt PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/AtlasPropertyKeyToPropertyKey.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/ElementDeletedCheckingInvocationHandler.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/GraphPerTenantStrategy.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/GraphReadLockInvocationHandler.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphDatabase.java
>  PRE-CREATION 
>   graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphEdge.java 
> PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphElement.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphGraph.java 
> PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphGraphQuery.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphIndex.java 
> PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphIndexQuery.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphIndexQueryResult.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphManagement.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphMetadata.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphPropertyKey.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphVertex.java 
> PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphVertexQuery.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/MultiTenancyDisabledStrategy.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/PartitionPerTenantStrategy.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/TenantGraphStrategy.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/Cardinality.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/GraphDatabaseClient.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/GraphDatabaseConfiguration.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/IGraphDatabaseClient.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/IndexStatus.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/AbstractGraphAction.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/ClearGraphAction.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/ElementIdListPropertyValue.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/ElementIdPropertyValue.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/GetVertexDataAction.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/IGraphAction.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/IPropertyValue.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/Index.java 
> PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/IndexProperty.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonEdge.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonErrorResponse.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonGraphElement.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonGraphInfo.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonGremlinQuery.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonIndexQueryResult.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonNewVertex.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonResponse.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonVertex.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonVertexData.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/PropertyDataType.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/PropertyKey.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/PropertyValue.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/Schema.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/ElementChanges.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/ElementIdListInfo.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/ElementProperty.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/ElementType.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/NewEdge.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/UpdateScriptBinding.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/exception/BadRequestException.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/exception/GraphDatabaseException.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/exception/HttpException.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/exception/InternalServerException.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/exception/NotFoundException.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/graphson/AtlasElementPropertyConfig.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/graphson/AtlasGraphSONMode.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/graphson/AtlasGraphSONTokens.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/graphson/AtlasGraphSONUtility.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/ActionTranslationContext.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/GremlinQuery.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/QueryElement.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/QueryGenerationResult.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/CollectExpression.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/CreatePartitionExpression.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/DefaultGraphTraversalExpression.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/EvaluableGremlinExpression.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/GetElementExpression.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/GetVertexDataExpression.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/GraphTraversalExpression.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/IndexQueryExpression.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/InstanceOfExpression.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/InterpolatedStringExpression.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/TransformQueryResultExpression.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/TraversalSourceExpression.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/AbstractHasStep.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/GraphStep.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/GremlinEvaluationResult.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/GremlinStep.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/HasStep.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/OrStep.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/ToListStep.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/VertexStep.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/WithinStep.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/FetchTraversalStatement.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/ForLoopStatement.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/IfStatement.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/ImportStatement.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/PreGeneratedStatement.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/TryCatchStatement.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpCode.java 
> PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpRequest.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpRequestDispatcher.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpRequestHandler.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpResponse.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpRetryStrategy.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpUtils.java 
> PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/IBMGraphRequestContext.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/IHttpRequestDispatcher.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/IHttpRetryStrategy.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/IdleConnectionMonitorThread.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/RequestType.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/DefaultUpdatedEdge.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/DefaultUpdatedGraphElement.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/DefaultUpdatedVertex.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/ElementBackedPropertyMap.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/GraphTransaction.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/IBMGraphTransaction.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/ReadableUpdatedEdge.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/ReadableUpdatedGraphElement.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/ReadableUpdatedVertex.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/UpdatedEdge.java 
> PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/UpdatedGraphElement.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/UpdatedVertex.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/AllowedWhenDeleted.java
>  PRE-CREATION 
>   graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/Batcher.java 
> PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/Endpoint.java 
> PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/FileUtils.java 
> PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/GraphDBUtil.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/PersistentType.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/PossibleSuccessCase.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/PropertyIndex.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/PropertyValueToVerticesMap.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/SchemaSplitter.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/UpdateSchemaRetryStrategy.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/mt/ITenantRegistrationListener.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/main/java/org/apache/atlas/mt/MultiTenancyConstants.java
>  PRE-CREATION 
>   graphdb/ibm-graph/src/main/resources/graphUpdater.groovy PRE-CREATION 
>   
> graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/AbstractGraphDatabaseTest.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/GraphDatabaseQueryTest.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/GraphDatabaseTest.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/GraphQueryTest.java 
> PRE-CREATION 
>   
> graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/GraphTransactionTest.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/PropertyDuplicationTest.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/QueryBindingTest.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/SessionCreateTest.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/UpdateScriptLoggingOffTest.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/UpdateScriptLoggingOnTest.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/VertexQueryTest.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/tx/ElementBackedPropertyMapTest.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/tx/TransactionMultiUserTest.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/util/BatcherTest.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/util/PropertyValueToVerticesMapTest.java
>  PRE-CREATION 
>   
> graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/util/SchemaSplitterTest.java
>  PRE-CREATION 
>   graphdb/ibm-graph/src/test/resources/atlas-application.properties 
> PRE-CREATION 
>   graphdb/ibm-graph/src/test/resources/atlas-log4j.xml PRE-CREATION 
>   graphdb/ibm-graph/src/test/resources/credentials.json PRE-CREATION 
>   graphdb/ibm-graph/src/test/resources/log4j.xml PRE-CREATION 
>   graphdb/ibm-graph/src/test/resources/update-logging-off-log4j.xml 
> PRE-CREATION 
>   graphdb/ibm-graph/src/test/resources/update-logging-on-log4j.xml 
> PRE-CREATION 
>   graphdb/pom.xml 2112938f 
>   graphdb/src/test/java/org/apache/atlas/graph/GraphSandbox.java PRE-CREATION 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java
>  9624c99f 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphDatabase.java
>  5af90d8c 
>   
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/AbstractGraphDatabaseTest.java
>  2dca50eb 
>   
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java
>  ade395be 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java
>  6a610755 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphDatabase.java
>  dfb53545 
>   
> graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/AbstractGraphDatabaseTest.java
>  7f3a436a 
>   
> graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/Titan1DatabaseTest.java
>  6db0da83 
>   pom.xml 934be23c 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  874487cb 
>   
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java
>  9f68c9a0 
>   
> repository/src/main/java/org/apache/atlas/gremlin/GremlinExpressionFactory.java
>  ff5a58c9 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java
>  0c5cac68 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  47dccf19 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/IAtlasGraphProvider.java
>  a2cac2df 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
>  c3e25bda 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  2f298ba4 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  e873e91b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java
>  1bfe3b90 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java
>  39c4dd93 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
>  560b3385 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
>  b76dfefa 
>   
> repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java 
> 8fb1793e 
>   
> repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala
>  752a522c 
>   repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 
> 3a310a77 
>   repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 6656dc67 
>   repository/src/test/java/org/apache/atlas/RepositoryServiceLoadingTest.java 
> 6e13077e 
>   repository/src/test/java/org/apache/atlas/TestMetadataModule.java 
> PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/TestUtils.java f09aa5ac 
>   
> repository/src/test/java/org/apache/atlas/discovery/DataSetLineageServiceTest.java
>  da2b4426 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  f3fdf085 
>   
> repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java
>  6a1979a0 
>   
> repository/src/test/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepositoryTest.java
>  a9dfee33 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/AbstractGremlinQueryOptimizerTest.java
>  2dda8536 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java
>  f0424ab9 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
>  9f32b853 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexerTest.java
>  1716ac53 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java
>  38319201 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java
>  a2fffe7a 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java
>  b87f7fd9 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/TestIntSequence.java
>  b8eefca1 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java
>  84ad72c8 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java
>  f1c4e48f 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
>  acb80754 
>   
> repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java
>  732a3821 
>   
> repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheTest.java
>  6c6c959e 
>   
> repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheTestModule.java
>  a1d7a745 
>   
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java
>  2b72f2a1 
>   repository/src/test/resources/credentials.json PRE-CREATION 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala acc70b5e 
>   repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala 
> bb44686c 
>   typesystem/src/test/resources/atlas-application.properties 5ffde5e5 
>   typesystem/src/test/resources/credentials.json PRE-CREATION 
>   webapp/pom.xml 28bd7ea6 
>   
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
>  473c78df 
>   webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 
> 7badd1e6 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 
> f079d631 
>   
> webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java
>  da221fc1 
>   webapp/src/test/java/org/apache/atlas/web/listeners/TestModule.java 
> b00080f1 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java
>  ee4057d4 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java
>  4f8badf1 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 
> 21060d14 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java
>  87d8719f 
>   
> webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTest.java
>  dc3b936b 
>   
> webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java
>  5d4ca972 
> 
> 
> Diff: https://reviews.apache.org/r/58803/diff/2/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/56724/
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Reply via email to