----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58746/#review173594 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java Line 418 (original), 425 (patched) <https://reviews.apache.org/r/58746/#comment246580> I assume this would be valid to add a mandatory attribute, if there were no instances. There needs to be a way to change the shape of an entity to add a mandatory field. Otherwise users would need to hack the graph store. It would be worth tracking this requirement to change the shape an an entity to add a manditory attribute. I suggest that a change like this would mean we would need to version the new shape; so requests for the old and new shape could be honoured. Will we support adding a mandatory attribute to a deleted entitydef then making it active? - David Radley On May 2, 2017, midnight, Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58746/ > ----------------------------------------------------------- > > (Updated May 2, 2017, midnight) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Suma Shivaprasad. > > > Bugs: ATLAS-1730, ATLAS-1736 and ATLAS-1747 > https://issues.apache.org/jira/browse/ATLAS-1730 > https://issues.apache.org/jira/browse/ATLAS-1736 > https://issues.apache.org/jira/browse/ATLAS-1747 > > > Repository: atlas > > > Description > ------- > > 1. Added empty attribute(s) check > 2. Dealing with special characters like $,%,{,} (titan treats these specially) > 3. Update of attribute type is not allowed anymore > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > 6f1b80c8 > > repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java > 7037d1eb > > repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java > c08bb881 > > > Diff: https://reviews.apache.org/r/58746/diff/5/ > > > Testing > ------- > > mvn clean package executes successfully > > > Thanks, > > Apoorv Naik > >
