----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58831/#review173539 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On May 1, 2017, 5:23 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58831/ > ----------------------------------------------------------- > > (Updated May 1, 2017, 5:23 p.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-1722 and ATLAS-1724 > https://issues.apache.org/jira/browse/ATLAS-1722 > https://issues.apache.org/jira/browse/ATLAS-1724 > > > Repository: atlas > > > Description > ------- > > **Background** > > - See [ATLAS-1724](https://issues.apache.org/jira/browse/ATLAS-1724) > - See [ATLAS-1722](https://issues.apache.org/jira/browse/ATLAS-1722) > > Overall status of the _Export_ operation is what is denoted by > _AtlasExportResult.operationStatus_. This is present in the JSON > _atlas-export-info_ within the exported ZIP file. > > **Implementation Approach** > > Several starting entities are specified, one of the following options using: > - _options_ like _matches_, _startsWith_, etc options. > - more than one items in _itemsToExport_ parameter. > > Internally, operation status for each of the starting is maintained. > > Once all operations are done, overall status is computed. > > **Unit test improvement** > - Added _PowerMock_ that aid _whitebox testing_. See patch for details. > > > Diffs > ----- > > repository/pom.xml f1c38b45 > > repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java > 73c3140d > > repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java > a7c70a97 > > > Diff: https://reviews.apache.org/r/58831/diff/2/ > > > Testing > ------- > > Unit tests for: > - Computing overall operation status. > - Updated _ExportServiceTest_. > > Executed unit tests and integration tests for _Export_ & _Import_ and > _Repository_. > > End user testing: > - _Import-Export_ end-to-end scenario execution. > > > Thanks, > > Ashutosh Mestry > >
