-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57241/
-----------------------------------------------------------

(Updated March 2, 2017, 3:03 p.m.)


Review request for atlas.


Changes
-------

addressed review comments


Bugs: ATLAS-1621
    https://issues.apache.org/jira/browse/ATLAS-1621


Repository: atlas


Description
-------

Fix for the failed ITs:
Failed tests:
EntityJerseyResourceIT.testAddNullPropertyValue:423 Expected 
AtlasServiceException
EntityJerseyResourceIT.testAddReferenceProperty:449->addProperty:467 » 
AtlasService
EntityJerseyResourceIT.testEntityDeduping:264 » AtlasService Metadata service 
...
EntityJerseyResourceIT.testPartialUpdate:739 » AtlasService Metadata service 
A...
EntityV2JerseyResourceIT.testAddNullPropertyValue:335->createHiveTable:443->createHiveTable:452
 expected object to not be null
EntityV2JerseyResourceIT.testEntityDeduping:197 » AtlasService Metadata 
servic...
org.apache.atlas.web.resources.EntityV2JerseyResourceIT.testEntityInvalidValue(org.apache.atlas.web.resources.EntityV2JerseyResourceIT)
Run 1: PASS
Run 2: EntityV2JerseyResourceIT.testEntityInvalidValue:272 expected:<null> but 
was:<AtlasEntityHeader{guid='d8cd8064-25cf-490d-aa88-5a93392677de', 
status=ACTIVE, displayText=null, classificationNames=[],, 
AtlasStruct{typeName='hive_db_v2', attributes=[name:LMPplE6apZ]}}>
EntityV2JerseyResourceIT.testSubmitEntity:103->createDBAndTable:437->createHiveTable:443->createHiveTable:452
 expected object to not be null
EntityV2JerseyResourceIT.testSubmitEntityWithBadDateFormat:296 expected object 
to not be null
MetadataDiscoveryJerseyResourceIT.setUp:64->BaseResourceIT.createInstance:234 
» AtlasService
Tests run: 135, Failures: 10, Errors: 0, Skipped: 17


Diffs (updated)
-----

  client/src/main/java/org/apache/atlas/AtlasClientV2.java af7dbbf 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 61657a1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
 a3d951d 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateV1Test.java
 a198e61 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
6d902db 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 288ef82 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 
0c1ffd3 
  webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 
0bcabb7 
  
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 
b37dbca 
  
webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
 e0e32a8 


Diff: https://reviews.apache.org/r/57241/diff/2/

Changes: https://reviews.apache.org/r/57241/diff/1-2/


Testing
-------

mvn clean verify -pl webapp -DskipUTs - all ITs tests suceeded
mvn clean install (in progress)


Thanks,

Sarath Subramanian

Reply via email to