> On Feb. 23, 2017, 7:23 p.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java, > > line 330 > > <https://reviews.apache.org/r/56860/diff/1/?file=1644999#file1644999line330> > > > > handle map case as well? > > David Kantor wrote: > Maps are specifically not supported for inverse reference updating, in > both the legacy code I delivered recently for ATLAS-1551 and these changes - > if the inverse reference is a map, what would be used for the key when adding > the map entry? The map attribute itself can have a inverse reference, and if > that inverse reference is not a map, it will be automatically updated. I > will add a test to verify that use case.
Makes sense. Thanks - Suma ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56860/#review166552 ----------------------------------------------------------- On Feb. 22, 2017, 11:48 p.m., David Kantor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56860/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2017, 11:48 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1552 > https://issues.apache.org/jira/browse/ATLAS-1552 > > > Repository: atlas > > > Description > ------- > > Automatic update of inverse references in V2 (V1?) code path. > > > Diffs > ----- > > intg/src/test/java/org/apache/atlas/TestUtilsV2.java > 84e17cb364fbf6d07b2211d85e336d8146fdb684 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java > 49d5a080158e3e54fd917a13f743f1cf495e66b0 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 09f69dbe6f519d84ae8e223532fc5adaa411ed9b > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java > 555f0acc22c4bec67f1a2a4064acad66e939747a > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateHardDeleteV1Test.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateSoftDeleteV1Test.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateV1Test.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/56860/diff/ > > > Testing > ------- > > Ran all unit and integration tests with no regressions. > > > Thanks, > > David Kantor > >
