> On Feb. 14, 2017, 10:48 p.m., David Kantor wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java, > > lines 177-211 > > <https://reviews.apache.org/r/56535/diff/3/?file=1633687#file1633687line177> > > > > This duplicates code in deleteByIds() - instead, it should simply > > delegate to deleteByIds() after the isEmpty() check e.g. > > > > return deleteByIds(Collections.singletonList(guid));
This is fixed already in the last diff. Hence dropping the issue - Suma ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56535/#review165581 ----------------------------------------------------------- On Feb. 14, 2017, 10:34 p.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56535/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2017, 10:34 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1547 > https://issues.apache.org/jira/browse/ATLAS-1547 > > > Repository: atlas > > > Description > ------- > > Added UTs for delete operations > > > Diffs > ----- > > addons/models/0030-hive_model.json 33ba156 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java > 93a77e0 > intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 4e3c795 > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 2f2d44f > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > 2abc30b > intg/src/test/java/org/apache/atlas/TestUtilsV2.java f268e48 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 69b22ff > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > c6a7206 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > 61adf2b > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 072d10d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java > fe0db39 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java > 7e3068b > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java > bb7de4a > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java > PRE-CREATION > server-api/src/main/java/org/apache/atlas/RequestContextV1.java 23eb4ce > > Diff: https://reviews.apache.org/r/56535/diff/ > > > Testing > ------- > > Need to fix a test failure in > AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference > > > Thanks, > > Suma Shivaprasad > >
