----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56442/#review165126 -----------------------------------------------------------
Ship it! Looks good to me! - Greg Senia On Feb. 8, 2017, 12:52 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56442/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 12:52 p.m.) > > > Review request for atlas, keval bhatt and Madhan Neethiraj. > > > Bugs: ATLAS-1538 > https://issues.apache.org/jira/browse/ATLAS-1538 > > > Repository: atlas > > > Description > ------- > > Currently in Altas , AtlasLdapAuthenticationProvider has > getLdapBindAuthentication method which used for openldap authentication. > Added new method getLdapAuthentication as a fallback to take care of failures > in login. > > > Diffs > ----- > > > webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java > f5ef058 > > Diff: https://reviews.apache.org/r/56442/diff/ > > > Testing > ------- > > Tested atlas ldap login both the methods & fallbacks. > Atlas Maven build completed without issue. > > > Thanks, > > Nixon Rodrigues > >
