----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56380/#review164492 -----------------------------------------------------------
Fix it, then Ship it! Rest looks good to me addons/models/0060-hbase_model.json <https://reviews.apache.org/r/56380/#comment236263> hbase_model.json is a placeholder for now, right? I suggest we file a JIRA to revise the HBase model later intg/src/main/java/org/apache/atlas/type/AtlasStructType.java (line 114) <https://reviews.apache.org/r/56380/#comment236290> Code in Line 115-125 and 127-137 is common. Please move it outside the if check - Vimal Sharma On Feb. 7, 2017, 11:06 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56380/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 11:06 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1526 > https://issues.apache.org/jira/browse/ATLAS-1526 > > > Repository: atlas > > > Description > ------- > > constraints foreignKey/mappedFromRef introduced in v2 doesn't handle all use > cases of legacy flags isComposite/reverseAttributeName. Hence replace these > constrainsts with new constraints "owner" and "inverserRef(attribute=attr)" > > > Diffs > ----- > > addons/models/0030-hive_model.json 5ae16cf > addons/models/0060-hbase_model.json 5febbbc > addons/models/0080-storm_model.json 344227d > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > 2c00f54 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 761eef5 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java f444e93 > intg/src/test/java/org/apache/atlas/TestUtilsV2.java b4aa8aa > intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 032dce0 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > d48c87e > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > f507ae0 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java > 2e9e5e4 > webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 1559eb9 > webapp/src/main/java/org/apache/atlas/util/RestUtils.java cecf636 > > Diff: https://reviews.apache.org/r/56380/diff/ > > > Testing > ------- > > updated unit tests and verified that existing unit tests pass > > > Thanks, > > Madhan Neethiraj > >
