> On Jan. 28, 2017, 8:07 p.m., Sarath Subramanian wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java, line 56 > > <https://reviews.apache.org/r/56049/diff/1/?file=1618230#file1618230line56> > > > > lock wait time 15 seconds is very high? should this value be made > > configurable from atlas-application.properties?
15 seconds is max-wait-time. Most calls should wait far shorter. There is another version of lockTypeRegistryForUpdate() which takes max-wait-time as argument. Updated AtlasTypeDefGraphStore to pass value read from configuration. - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56049/#review163411 ----------------------------------------------------------- On Jan. 29, 2017, 12:51 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56049/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2017, 12:51 a.m.) > > > Review request for atlas and Abhay Kulkarni. > > > Bugs: ATLAS-1472 > https://issues.apache.org/jira/browse/ATLAS-1472 > > > Repository: atlas > > > Description > ------- > > Updated type-registry to ensure that type changes (add/update/delete) are > serialized > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java e7dbb1c > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 3de0215 > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 089bebee > intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java 6d3c312 > intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 710840f > intg/src/test/java/org/apache/atlas/type/TestAtlasTypeRegistry.java 60a09a1 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java > f7c2931 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java > 287ef09 > > Diff: https://reviews.apache.org/r/56049/diff/ > > > Testing > ------- > > - added unit tests to simulate type updates from multiple threads > > > Thanks, > > Madhan Neethiraj > >
