Atlas team,

 

I would request you to consider creating patches with the following steps. It 
will save reviewers and committers considerable time in dealing with patch 
apply/revert, adding the commit message and author info etc.

 

Initial patch for a review:

  1. git add <files to be included in the patch>

  2. git commit -m “ATLAS-1234: commit message that will go into git”

  3. git format-patch origin/master

  4. rename the file to: ATLAS-1234.patch

  5. Attach ATLAS-1234.patch to the JIRA and create a review in review board.

 

Subsequent updates for the same review:

  1. git add <files to be updated in the patch>

  2. git commit -m “updated”

  3. merge this commit with earlier one:

     - git rebase -i

     - a file should open up in your text editor. Change the first word in the 
second line - from “pick” to “s”

     - another file should open up in your text editor. Remove the lines for 
the second commit message.

  4. git format-patch origin/master

  5. rename the file to: ATLAS-1234-1.patch

  6. Attach ATLAS-1234.patch to the JIRA and create a review in review board.

 

Thanks,

Madhan

Reply via email to