> On Jan. 11, 2017, 11:53 p.m., Apoorv Naik wrote: > > .gitignore, line 39 > > <https://reviews.apache.org/r/54858/diff/2/?file=1596621#file1596621line39> > > > > Would this not affect the distro module? All the python executables > > reside under distro/src/bin > > > > Also which binaries are you looking to exclude ? All the bin dirs that > > I see are locate under target for each module so that should get excluded > > as per the current gitignore
I am happy to go back to the first fix I submitted - it you would prefer to commit that rather than this top level rule based one. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54858/#review161329 ----------------------------------------------------------- On Jan. 13, 2017, 4:35 p.m., David Radley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54858/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2017, 4:35 p.m.) > > > Review request for atlas and David Kantor. > > > Repository: atlas > > > Description > ------- > > Added .gitignore files so git does not see binary files as changed. Atlas > type system project has a strange .gitignore that I have not touched. I > notice it contains ignores for Eclipse files, but the way we run it the > eclipse files are not picked up by git. > > > Diffs > ----- > > .gitignore cf2ef7445407f846329b0849d23dcb0aecc4d242 > > Diff: https://reviews.apache.org/r/54858/diff/ > > > Testing > ------- > > git status shows no untracked changes after a compile. > > > Thanks, > > David Radley > >
