Wei Shao wrote:
Wan-Teh Chang wrote:
[EMAIL PROTECTED] wrote:
Hi,
HASH_* APIs provide a good wrapper for the hashing algorithms.
But secsign.c does not use any of these. It instead calls
create/update/end directly on the hash context.
Would it be better to use HASH_* APIs in secsign.c?
We could use HASH_* APIs in secsign.c. Perhaps the
author of secsign.c wanted to save the function call
overhead and decided to call create/update/end directly
on the hash context. Compared with calling HASH_Create,
we also save a malloc call this way.
What do I need to do if I want to propose a change to use HASH_* APIs
in this implementation?
This requires changes to the underneath structure for the opaque
SGNContext.
There is a principle for software maintenance that
"if it ain't broke, don't fix it." Code using internal
functions is definitely not broken. Please don't propose
this change.
To propose a change, the best approach is to open a bug
report in https://bugzilla.mozilla.org/ against the product
NSS:
https://bugzilla.mozilla.org/enter_bug.cgi?product=NSS
Then, create a patch for your proposed change and attach the
patch to the bug report. (We discussed how to create a patch
in this newsgroup recently.)
Wan-Teh
_______________________________________________
dev-tech-crypto mailing list
dev-tech-crypto@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-tech-crypto
