Helson, Thanks for you reply :)
> > What is the ss->securityHandshake used for? > > I think it may now be unused. I think it was part of the old SOCKS > implementation that was abandoned. > This probably doesn't matter as much, but ssl_SecureConnect sets the handshake function using ss->securityHandshake, while SSL_ResetHandshake sets it using ss->handshake. ssl_SecureConnect case: http://lxr.mozilla.org/security/source/security/nss/lib/ssl/sslsecur.c#915 SSL_ResetHandshake case: http://lxr.mozilla.org/security/source/security/nss/lib/ssl/sslsecur.c#216 If ss->securityHandshake is not used anymore, maybe both functions should set the handshake function using the ss->handshake function pointer to avoid confusion. Also, would getting rid of the ss->securityHandshake pointer altogether be possible, too? This would avoid some possible confusion, too. Just an idea, there might be good reasons (that I don't know) why this shouldn't be done... Regards, Peter _______________________________________________ dev-tech-crypto mailing list dev-tech-crypto@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-tech-crypto
