Can we make the script fail with an error if they don't have the right version? Maybe with --use-older-python-and-pray they can use to try anyway. If we just warn they are likely to miss the warning and just notice it doesn't work, whereas if we fail first, they'll at least know something is wrong, and then they could try anyway knowing that it probably won't work.
jack. On Wed, Oct 18, 2017 at 1:31 PM, Simon Sapin <simon.sa...@exyr.org> wrote: > Servo downloads appropriate versions of Rust and Cargo using Python’s > urllib2. At some point, https://static.rust-lang.org started requiring TLS > SNI (I think when it moved to a CDN?) and we had issues with downloads > failing on CI or on contributor’s machines because of old Python versions. > > So we moved to using https://static-rust-lang-org.s3.amazonaws.com instead, > which does not require SNI. However, that URL is not considered stable: > > https://internals.rust-lang.org/t/public-stable-rust-services/6072 > > I don’t expect it’ll go away any time soon, but we should still consider not > relying on it. > > > I propose that we move back to using https://static.rust-lang.org, and > document that Python 2.7.9 or more recent is required, and print a warning > when and older version is used. > > Support for SNI was added in 2.7.9, which was released in December 2014. > Debian has had a recent enough default version since Debian 8.0 Jessie > released in April 2015, and Ubuntu since Vivid Vervet 15.04 released in > April 2015. > > Travis-CI still uses Ubuntu 14.04 LTS, but using 'language: python' in > .travis.yml gives an environment with a recent enough Python version. > > > Thoughts ? > > -- > Simon Sapin > _______________________________________________ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
