"Backed out changeset 90036d4d378e (bug 17564) because gecko-side patch caused bustage on Windows. r=backout on a CLOSED TREE"
I see issues in that: - Mentioning a Mercurial changeset hash when just a PR number is enough - Putting the reason of the backout directly in the title instead of the message - Saying "bug X" where X is a Servo PR number (so it should say #17564) - Saying "on a CLOSED TREE" which AFAIK serves no purpose > Le 30 juin 2017 à 00:22, Simon Sapin <ssa...@mozilla.com> a écrit : > > On 19/06/2017 20:48, Lars Bergstrom wrote: >> tldr: If you see some PRs from the moz-servo-sync GitHub user with a >> priority of "treeclosed," it's because those must be landed into Servo ASAP >> to support Firefox backouts. > > Where do we file bugs on this tool? It creates a new PR that mentions the > number of the PR being reverted, which is good. > > It should also comment on *that* PR to let the people involved that they’ll > have something to fix and they’ll need to try to land this again. We don’t > want improvements being forgotten after being backed out. _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
