On Fri, Feb 10, 2017 at 10:04 PM, Cameron McCormack <c...@mcc.id.au> wrote:
> On Sat, Feb 11, 2017, at 11:54 AM, Bobby Holley wrote: > > Update: This is now on autoland, so please start using the new workflow. > > Thanks to Greg and Manish for pushing it over the line! > > Great work! > > > The crashtest job is currently failing - I can't tell whether it's a > > one-off (in which case we should disable the crashtest and file a bug) or > > whether it portends more failures that we should probably look into > > directly. I'll investigate soon if nobody else does before then. > > The assertion failures are due to bug 1331294 landing. The crash I'm > not sure about. I'll take a look. > I just did a few crashtest runs locally while. Adding skip-if(stylo) to layout/base/crashtests/404218-1.xhtml and dom/xbl/crashtests/336960-1.html lets us get through the crashtest (thought we still have the negative leaks). If somebody has a minute to push that to autoland and file a followup bug to investigate (NI me please) I'd appreciate it - I haven't had time to set up MozReview on my new machine, so I can't push to autoland myself. > By the way, are we waiting until the leaks on the reftest jobs are > solved before running them on autoland? > Not explicitly no - I'm not entirely sure why the reftest jobs aren't running, but we could presumably turn them on. That said, I do think we should establish a bit better hygiene than we had on incubator in terms of only displaying green jobs (we can make non-green jobs hidden by default on treeherder view). Once this hits central and inbound, we want developers to notice when they break stylo rather than just glossing over it. Looks like there's a solution for the "negative leaks" issue in bug 1334579. I'm not sure if anyone has investigated the calc leak yet, but we should. bholley _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
