Currently, pull requests can not land until `./mach test-tidy` passes,
which includes checking that we’re not building more than one version of
any crate.
This usually makes sense: duplicate crates increase binary size and
sometimes cause build errors ("expected `url::Url`, found `url::Url`).
But sometimes this is a pain to fix.
https://github.com/servo/servo/pull/8446 (a Rust upgrade started 17 days
ago) is nearly ready to land except for 54 such tidy errors:
https://gist.github.com/anonymous/94c681bf50df3b784c84
All of them are to be fixed in repositories other than servo/servo (most
of which don’t have a maintainer in the Servo team). Most of them are
about libc 0.1 and 0.2 (which is mostly type and function definitions,
so maybe no binary size impact?). None of them cause build errors.
In this case, I feel like this check is more of a burden than it helps.
What do you think of making it advisory rather than a hard requirement?
--
Simon Sapin
_______________________________________________
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo
