On 03/11/15 22:08, Robert O'Callahan wrote:

Why not create a Mochitest compatibility layer over testharness.js so
that tests that only use SimpleTest.waitForExplicitFinish(),
SimpleTest.finish(), is(), todo() and ok() can run on Servo with trivial
changes?

A few reasons I am skeptical of this:

* Mochitests test gecko behaviour, not standardised behaviour. These can and do differ. Therefore they are even less trustworthy than the average test.

* Mochitests are really written assuming the full gecko featureset. Given the total lack of isolation between asserts, they may behave rather unexpectedly and misleadingly in a browser not having all those features.

* In the long term having multiple APIs for writing tests that people have to learn in order to read tests is a big net negative. If we allow mochitests to be upstreamed with a shim we should expect other vendors to do the same, and to end up with half a dozen possible test formats.

In addition, I don't think that using mochitests which don't use internal APIs helps at all with the original problem of testing things like dynamic style changes that require internal-only APIs to trigger.
_______________________________________________
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo

Reply via email to