Le 15 oct. 2015 à 14:42, Lars Bergstrom <larsb...@mozilla.com> a écrit :
> - Automatic rebasing > > Right now, our commit log history is somewhat mumbly-jumbly. The autolander > adds a commit for the pull request detailing who reviewed it, etc., but the > commit itself sits in the history wherever `master` was on the commiter’s > local machine when they did the work. This makes looking at a given commit > and figuring which PR it landed in require either some extra tooling or > git-fu that most users don’t have. I'm against this for the following reasons: - Makes it harder to distinguish which commits go together, everything is linear so there are no "commits groups" anymore. - Makes it harder to bisect, we can't distinguish branch tips easily anymore, so we can't skip internal commits easily when bisecting. Tests aren't run on commits that were not branch tips, so bisecting could fail for whatever reason at every step. - Makes it harder to see which local branches were merged through git branch --merged (and similar commands) because all commits are now cherry-picked by Homu. In general, I don't even buy the argument that "merges make the log unreadable". _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
