On 02/06/15 18:46, Manish Goregaokar wrote:
Thanks to some great work by jgraham we've gated
<https://github.com/servo/saltfs/pull/34> builds by the css tests (linux3).

The mac3 builder will continue to run css tests and will now become red
when the build fails. This will not block PRs though.

If you come across any intermittents let jgraham know (and disable them).
We can un-gate if there are too many of them.

Some additional details about running the tests:

In order to run the tests locally use |mach test-css|. Note that the tests take a while to run (particularly in debug) so for development you may be better off selecting a subset of the tests for the feature you are changing (related note: I think our test volume is now high enough that something like gecko's try server would be a big win).

If you need to update expectation data in order to get a PR landed the best approach is to use the raw log files from buildbot as input for the |mach css-update| command. These are visible on the waterfall page [1] as wpt_raw.log links, but note that you need to add /text to the url to get a plain text version. For example, one might update the metadata like:

curl http://build.servo.org/builders/linux2/builds/1914/steps/shell_1/logs/wpt_raw.log/text > linux.log curl http://build.servo.org/builders/mac3/builds/76/steps/shell/logs/wpt_raw.log/text > osx.log
./mach css-update linux.log osx.log

This will make a local commit with the relevant metadata changes.

Thanks to larsberg and Manishearth for doing the ops side of this change, and generally being super-helpful.

[1] http://build.servo.org/waterfall

_______________________________________________
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo

Reply via email to