Le 28/04/2015 06:52, Boris Zbarsky a écrit :
On 4/27/15 8:38 PM, Josh Matthews wrote:
https://github.com/servo/servo/wiki/Meeting-2015-04-27
I've mentioned this a few times, but...
For a layout engine, being able to attach an actual testcase to a bug
report is _really_ useful once you get out of "just build it" mode and
into "fix all the bugs in this thing you built" mode. Github issues
simply have no way to do this that I've been able to find. You can
put testcases on jsfiddle or other such services, but it's really hard
to do minimal testcases that way because of all the things those
services pull in, it's impossible to test some things (e.g. parser
issues, quirks mode) because there's little control over the markup,
and there are absolutely no guarantees your testcase will be around in
5 years when you want to see what that code change was trying to fix.
Another possibility is for the reporter to make a PR with the test case.
It's annoying because the reporter has to choose a place. A dedicated
directory with only a .gitkeep could be created. A label could
differenciate "normal" PRs with "issue" PRs.
It also requires a change of perspective on what "Pull Requests" are...
or maybe not given all PRs certainly already all include tests.
There is also a way to turn an issue into a PR.
http://engineroom.trackmaven.com/blog/using-hub-and-fish-to-turn-github-issues-into-pull-requests/
I'm not sure why this feature isn't exposed in the default Github UI.
David
_______________________________________________
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo
