I've finally got a sketch of my plans to remove all of the @mut annotations from Servo's DOM. You can see it at https://gist.github.com/jdm/7693770, but here's the breakdown of the improvements:

* no more AbstractNode (\o/) - we can actually use JSManaged<Element> when we want to refer to something derived from Element now. * actually fulfils the contract that the SpiderMonkey GC owns the sole reference
* no need to add as_foo methods for downcasting

Breaking it down further, one of the biggest changes is in the implementation of downcasting and upcasting. Upcasting a JSManaged<Foo> to a JSManaged<Bar> is a statically-checked operation that should be free at runtime. This is enforced by a series of empty traits that each derived class much implement (ie. see EventTargetBase), such that any value passed to Bar::from() must be a type that implements BarBase. In a similar fashion, downcasting is also statically-checked (does the cast even make sense?), before performing a dynamic assertion (is this base class actually an instance of the derived type?). Therefore, when calling Foo::to(), the value passed must implement the FooDerived trait with an appropriate boolean is_foo method implemented.

These casting changes may not look like a big improvement at first, but the important consideration is the the upcasting traits can be automatically generated completely from WebIDL definitions, so that boilerplate should be essentially free. For downcasting, each type that is on an inheritance chain will need to implement a single trait with a single boolean method that performs the required dynamic check; all other boilerplate can also be generated from WebIDL definitions, and is therefore essentially free.

I welcome feedback about this sketch. For a quick look at how it can be used by consumers, see main() in jsgc.rs.

Cheers,
Josh
_______________________________________________
dev-servo mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-servo

Reply via email to