On 10/31/2019 1:02 PM, Jason Orendorff wrote:
On Thu, Oct 31, 2019 at 4:10 AM Paolo Amadini <[email protected]> wrote:// INCORRECT //await Promise.allSettled([promise1, promise2]); The last example silently loses any rejection state.Ignoring the awaited value here is like using `catch {}` to squelch all exceptions, or ignoring the return value of an async function or method, or any other expression that produces a Promise. Do we have lints for those pitfalls? I'm kind of surprised that there doesn't seem to be a built-in ESLint lint for `catch {}`.
Correct, what makes this example worth noticing is that it looks very similar to other valid uses where we can ignore the resolution values, because they are "undefined" or irrelevant to the flow.
There's nothing special about tests here, right? Those patterns are fishy whether you're in a test or not.
I made the point with tests because in many cases, when racing promises there, every failure should be fatal, and at the same time we often legitimately drop return values that are irrelevant to the test. Cheers, Paolo _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
