The reasoning is: - If we don't rewrite existing test files then it will keep getting propagated in new tests as old ones get cloned. - It's a small cleanup that makes existing tests slightly easier to read (especially when combined with other boilerplate reduction). - I was under the impression until yesterday that type="application/javascript" was required on script tags in XUL documents (or maybe xul:script tags in any document). I assume I'm not the only one who's thought that or some variation of it - if we stop using the attribute then it would be one less out of the ordinary thing to deal with for Firefox development.
I'll think some more about if there’s a way to limit the risk of losing test coverage. Perhaps doing it in a couple of separate patches would result in a final patch that’s more manageable to review: first do simpletest.js and other common helper scripts tree-wide, then do full-replacement in folders that wouldn’t have a reason to test this specifically (browser/, devtools/, gfx/, particular dom/ subdirectories etc). Brian > On Apr 9, 2019, at 3:57 AM, Gijs Kruitbosch <gijskruitbo...@gmail.com> wrote: > > On 09/04/2019 11:16, James Graham wrote: > >> I also wonder if there are other non-wpt tests that would be broken by such >> a change?? > > This was my thought as well. Is there a compelling reason to want to do this > rewrite for extant HTML mochitest test files? > > ~ Gijs > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
