On Fri, Nov 30, 2018 at 09:57:00AM -0800, tcampb...@mozilla.com wrote: > Now that all of mozilla-central is been migrated to use clang-format > automated code formatting, the question of what should happen with editor > modelines at the top of files should be considered. > > https://bugzilla.mozilla.org/show_bug.cgi?id=clang-format > > Here are some options and some arguments I've heard. Please reply with > further ideas or rationale. I've not classified points as pro/con and leave > that up to the reader's interpretation. > > Option 1: Remove mode lines > - Devs are expected to run clang-format anyways (hopefully automated with a > hook of sorts) > - Devs are free to set their modeline configuration elsewhere > - If they aren't providing value, they deserve to be removed. > - Many of these were already inconsistent/wrong, so this might be an > opportunity to phase out > - Not all devs use vim/emacs, so we should think about workflows help that > doesn't need stuff in every single source file.
Even more, Debian-based vim packages have the modeline-reading feature disabled by default for security reasons (because they can, in fact, do anything), which makes vim modelines essentially useless to even a large number of vim users. Mike _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
