Sorry for the lag replying to this.

On 11/13/18 4:35 PM, James Graham wrote:
On 11/11/2018 17:57, Emilio Cobos Álvarez wrote:

web-platform-tests: Test coverage for all the values is pre-existing. There's unfortunately little coverage in WPT, but a lot in our selection and contenteditable tests.

Can we upstream some of these tests to wpt? I don't know if there are/were technical barriers that would prevent us doing that, but if user gestures are required, the new testdriver APIs might fill the gap, and if there is some other piece of missing functionality I would be interested to know what that is.
Part of the difficulty is that we want these tests to show the caret, which is something normal reftests don't. Right now all these reftests are here:


https://searchfox.org/mozilla-central/source/layout/base/tests/test_reftests_with_caret.html

I'm not quite sure why they couldn't be normal reftests with the ui.caretBlinkTime pref set to -1. Maybe David, Ehsan or Mats know.

But even with that, a lot of those require faking user input (like arrows and such), whose effect depends on platform conventions. We're using EventUtils for that right now, and skipping some tests in some platforms.

I know the events thing is technically possible in WPT, is there any example I could cargo-cult from?

I think in theory writing new caret tests with testharness.js and the event stuff would be useful, and it may be possible to submit some of the ones that don't depend on platform conventions.

 -- Emilio
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to