> On 2 Jun 2018, at 9:56 am, Emilio Cobos Álvarez <emi...@crisal.io> wrote:
> 
> Hi, just a quick PSA:
> 
> In bug 1465585 I switched all uses of mozilla::Move to std::move, and
> removed the former.
> 
> The reasoning for that is that it allows compilers to detect misuses of
> std::move and warn about them (-Wpessimizing-move / -Wself-move /
> -Wreturn-std-move).
> 
> Beware of some local mac builds maybe being broken. That should be fixed
> by bug 1270217 (thanks jwatt!).


FWIW, this breaks build with clang 6.0.0 on mac…

such as:
 0:04.70 
/Users/jyavenard/Work/Mozilla/obj-ff-dbg/dist/include/mozilla/Move.h:222:14: 
error: no type named 'move' in namespace ‘std'

which is ultra weird a Move.h properly includes <utility>

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to