On Monday, 9 April 2018 15:29:35 UTC-4, Randell Jesup wrote: > >As I indicated, those posts go into detail on why we are avoiding both > >comment and more complicated flag mirroring. > > > >Mark > > There's no obvious discussion of "flags" in the linked discussions you > gave; I find only a couple of references to "flag" - in a question from > gps. Given how long the thread is (52 posts), perhaps you can point to > something more specific? Thanks
gps's post is what I was talking about. It doesn't go into many details, but, to reiterate his main point, the mapping of disparate review systems is difficult and has lots of edge cases. To add a bit of specifics, the models behind review flags in BMO, which are independent objects associated with specific attachments, is very different from the way Phabricator treats reviews, which are particular states of a revision. It's doubtful we could ever have a perfect translation, so it would always be some sort of a hack. We've determined that a better solution is to expose Phabricator requests in Bugzilla as notifications and dashboards, as I linked in one of my replies above. Mark > > >On Sat, Mar 31, 2018 at 10:14 AM, Ben Kelly <bke...@mozilla.com> wrote: > > > >> On Sat, Mar 31, 2018, 10:09 AM Mark Côté <mc...@mozilla.com> wrote: > >> > >>> Regarding comment and flag mirroring, we've discussed this before: > >>> > >>> https://groups.google.com/d/msg/mozilla.dev.platform/ > >>> Y8kInYxo8UU/e3Pi-_FpBgAJ > >>> https://groups.google.com/d/msg/mozilla.dev.platform/ > >>> Y8kInYxo8UU/tsF7UfxvBgAJ > >>> > >>> Given that Phabricator is still new, I don't see any reason to reopen > >>> that discussion at this point, aside from noting that we have work in > >>> progress to include Phabricator requests in BMO's My Dashboard and > >>> notifications indicator (https://bugzilla.mozilla.org/ > >>> show_bug.cgi?id=1440828). > >>> > >> > >> What about comment mirroring? On my mobile so I haven't read all the past > >> threads, but my recollection is that your team did not want to implement > >> that feature. Personally, this is a huge concern for me. > >> > >> Thanks. > >> > >> Ben > >> > >> > >>> As for interdiffs, feel free to file a bug with any problems you see. We > >>> have a good relationship with upstream and can pass those on. Similarly > >>> with method names (which has been mentioned before but I can't find where > >>> at the moment). > >>> > >>> There is official documentation at https://secure.phabricator. > >>> com/book/phabricator/ which is linked from our Mozilla-specific docs ( > >>> http://moz-conduit.readthedocs.io/en/latest/phabricator-user.html) which > >>> in turn is linked in the left-hand menu in Phabricator. We can expand our > >>> own docs as needed if there are areas that are particularly confusing due > >>> to, say, expectations carried over from our other code-review tools. > > -- > Randell Jesup, Mozilla Corp > remove "news" for personal email _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
