On Fri, Feb 2, 2018 at 12:50 PM, Boris Zbarsky <bzbar...@mit.edu> wrote:

> On 2/1/18 6:40 PM, Nicholas Nethercote wrote:
>
>> - prefs.js, which is written by Firefox. Firefox should always generate
>> data that is accepted by the new parser
>>
>
> OK.  I assume we've double-checked that?  And that this was the case all
> along, for prefs extensions or about:config might have set in the past?
> (Especially the no-embedded-null thing.)
>

I don't know what you mean by "prefs extensions". It might be possible that
you could use about:config or the prefs API to set a string pref that
contains an invalid escape sequence that the parser will subsequently
reject. I will check that.


> We could make a backup copy of prefs.js if an error is discovered in it,
> so that when we write it out again the old thing can still be recovered if
> needed.


Perhaps I should implement error recovery, so that ill-formed prefs won't
cause subsequent prefs to be lost.

Nick
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to