On Wed, Jan 10, 2018 at 3:40 PM, Daniel Holbert <dholb...@mozilla.com> wrote: > I'd lean slightly towards allowing the syntax and making it actually skip > the include expression. This construct seems valuable to have in our > toolbox (to be used only sparingly, e.g. for cases of platform-specific > features).
Yeah I'm inclined to agree. I looked over the places where we are currently doing this (the 11 in layout/reftests that you found, plus 3 more in image/test/reftest/reftest.list) and in all cases it seems like the intent was to just skip the include entirely. So I'm planning to change the semantics to do that, and disallow other annotations like "fuzzy include foo/reftest.list" or "fails include foo/reftest.list" - we don't have any of those currently and I think disallowing them is the way to go. I've filed bug 1429580 for this issue. Cheers, kats _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
