On Wed, Jan 3, 2018 at 4:43 AM, Mark Banner <mban...@mozilla.com> wrote:
> On 24/12/2017 19:41, Ben Kelly wrote: > >> But I also see rules about cosmetic things like what kind of quotes must >> be >> used for strings. >> AFAICT this kind of rule does not have any tangible safety benefit. Its >> purely a cosmetic style choice. I don't see why we should bounce patches >> out of the tree if the author and reviewer of a component prefer to use >> single quotes instead of double quotes in a file. >> > As Jonathan already mentioned, the stylistic rules are designed to help > enforce a consistent style, and reduce code review cycles to address review > "nits" - benefiting both the submitter and reviewer. > > This also helps newcomers find and pick up the consist style quickly, > rather than having to "examine the files in the component and work out the > style that's used most" which is what we've had in the past. > > It's also of tremendous value to those of us whose work on Firefox requires them to interact with many different components; consistency across the codebase is a huge boon to our ability to dive into new things as they're needed. Alex _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
