On Tue, Dec 5, 2017 at 3:24 PM, Henri Sivonen <hsivo...@hsivonen.fi> wrote: > On Mon, Dec 4, 2017 at 2:04 PM, Masatoshi Kimura <vyv03...@nifty.ne.jp> wrote: >> * If by any chance a profile path contains non-ASCII characters on >> non-UTF-8 UNIX systems, Firefox 57.0.1 must have broken the profile just >> like 57.0 broke it on Windows. But we didn't hear any such complaints. > > Are you referring to > https://hg.mozilla.org/mozilla-central/rev/345fe119b8cf using > GetPath() on all platforms and not just Windows? > > Experimenting in an Ubuntu VM, Firefox 57.0.1 indeed fails to save > prefs and history (but saves the HTTP disk cache and various other > things) if the profile path has an illegal byte in it. Additionally, > on Debian-based systems generally, adduser only allows usernames (and, > thereby in the common case where the home directory matches the user > name, home directories) that conform to the POSIX portable username > rules (subset of ASCII). useradd appears to have no such safeguards.
If the glibc ja_JP.eucjp locale has been generated prior to login, LC_ALL is set to ja_JP.eucjp and the profile path contains a byte pair that's valid EUC-JP but invalid UTF-8, Firefox 57.0.1 saves prefs but doesn't save history or bookmarks and is unable to complete File: Save Page As... (fails silently before asking where to save even if the EUC-JP bytes are just in the profile path and not in the home directory path). Additionally, downloads fail it the download target path has non-ASCII EUC-JP bytes in it. So far, I've found Solaris documentation that rules out EUC-JP user names: https://docs.oracle.com/cd/E23824_01/html/821-1474/attributes-5.html#scrolltoc . In addition to Debian adduser enforcing POSIX username portability, I found an anecdote suggesting that some management tool of RHEL from years ago did, too. I haven't found conclusive documentation explaining that there can't be EUC-JP usernames and matching home directories out there on Linux or BSD systems. However, per the above observation about failure to save history, save bookmarks, invoke Save As... or download anything if the path has EUC-JP bytes, it seems safe to conclude that if an EUC-JP home directory name exists somewhere out there, Firefox is already very broken on such a system. -- Henri Sivonen hsivo...@hsivonen.fi https://hsivonen.fi/ _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
