On 19/10/2017 14:02, Ted Mielczarek wrote:
On Wed, Oct 18, 2017, at 07:51 AM, Mark Banner wrote:
Looping in firefox-dev as well, as I thin this is an important
discussion.
On 18/10/2017 09:28, David Teller wrote:
Hi everyone,
Yesterday, Nightly was broken on Linux and MacOS because of a typo in
JS code [1]. If I understand correctly, this triggered the usual
"undefined is not a function", which was
1/ uncaught during testing, as these things often are;
Part of the reason it was uncaught, is that there's no automated test
coverage for that bit of code. It is a migration from one version to the
other, but unless there is an explicit test (and I don't see one) that
line won't be hit.
Given this bit, would any of the suggestions in this thread actually
help? If we're not exercising this code in automated tests, would "fail
tests on uncaught exceptions" make any difference?
The only thing that might help (that has been discussed) is something
along the lines of flow - an analyser that could work out that 'spice()'
didn't exist, but Dave Townsend mentioned these don't seem to be viable
for us.
Therefore I think the migration code should be having automated tests -
it is the only way we can reliably detect these sort of failures at the
moment.
Mark.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
