On Sep 13, 2017 15:52, "Ben Kelly" <bke...@mozilla.com> wrote:
On Wed, Sep 13, 2017 at 4:44 AM, Henri Sivonen <hsivo...@hsivonen.fi> wrote: > I suggest we do the following: > > 1) Change the HTML parser behave more like Blink's: Raise the limit > to 513 elements deep and append elements violating the limit to the > 512th element on the stack instead of dropping them. (Since the > off-the-main-thread parser can't read from the DOM, the previous > sentence is defined in terms of the stack and not in terms of looking > up a parent as in Blink.) I already have the code for this. > > 2) Change the frame constructor limit to 1026. Rationale: This is > notably larger than 513 by being 513 times two and just within what > can be handled in the table-cell worst case on Mac and Linux with the > existing run-time stack size limits. > > 3) Increase the run-time stack size on Windows such that 1026-deep > display: table-cell doesn't overflow the stack. > Is it possible to have automated tests to verify these tunings remain valid as the tree is changed over time? Or maybe we already have those? My plan is to write a reftest that will fail if 1) frame construction stops too soon or 2) it crashes due to stack overflow. AFAICT, it has to be skip-if debug, because the stack frames are substantially larger in debug builds. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
