On Wed, Aug 30, 2017 at 06:26:18PM -0600, Eric Rescorla wrote:
> On Wed, Aug 30, 2017 at 4:41 PM, Jeff Gilbert <jgilb...@mozilla.com> wrote:
>
> > IMO: Never else-for. (or else-while)
> >
> > Else-if is a reasonable continuation of concept: "Well it wasn't that,
> > what if it's this instead?"
> > Else-for is just shorthand for "well it wasn't that, so let's loop
> > over something".
> >
> > Else-if is generally used for chaining, often effectively as an
> > advanced switch/match statement.
> >
> > I've never actually seen else-for, but I imagine it would be used for:
> > if (!foo) {
> > } else for (i = 0; i < foo->bar; i++) {
> > }
> >
> > I don't think this pattern has enough value to be acceptable as
> > shorthand. BUT, I didn't know it was a thing until now, so I'm
> > naturally biased against it.
> >
>
> I'm with Jeff here. Not even once.
>
> if (!foo) {
> } else {
> for(...) {
>
> }
> }
>
> As it happens, the style guide agrees with us, so I'm happy to quote it ;)
>
> "else should only ever be followed by { or if; i.e., other control keywords
> are not allowed and should be placed inside braces."
... because it was added today after this thread:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style$compare?locale=en-US&to=1296847&from=1263305
Mike
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
