On 16/08/17 01:26, Nils Ohlmeier wrote:
I guess not a lot of people are aware of it, but for WebRTC we still have two distinct implementations for the networking code. So if I understand the impact here right we just lost test coverage for probably a couple of thousand lines of code.
[…]
I’m not sure how others do it, but our low level C++ unit tests don’t have an e10s mode at all. Therefore we can’t simply delete the non-e10s WebRTC networking code either (without loosing a ton of test coverage).
If the networking code is only covered by C++ unit tests, there is separate code for non-e10s vs e10s, and the unit tests don't work in e10s mode doesn't that mean we currently don't have any test coverage for our shipping configuration on desktop? What am I missing?
_______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
